fix: sanitize import filenames in generated imports #2216
Conversation
βοΈ Deploy Preview for nuxt3-docs canceled. π¨ Explore the source changes: 5090279 π Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/62011f624917db00083ef739 |
This seems nice initiative and refactors anyway even until rollup is not supporting π But I guess we should move this fix to mlly for generation utils and refactor once. |
@danielroe Would you please help resolving merge conflicts? |
Current status is we are creating a new library in I suggest I wait to resolve merge conflicts until we have that repo created or a PR open in it. |
49fd805
to
e5b9ea0
Compare
@pi0 It would be good to get this merged in even if we still have upstream issues with vite to resolve. (Unless you think there's something else we should fix here?) |
π Linked issue
nuxt/nuxt#12909
β Type of change
π Description
We should consider whether we want to support the use case in the linked issue, although the PR is safe to merge and likely a good idea.
Note:
vite
androllup
themselves are not yet compatible with resolved ids containing'
so even with this PR, the original issue is not solved.π Checklist
pending feat: string-based codegen utilsΒ unjs/magicast#2