Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix: sanitize import filenames in generated imports #2216

Merged
merged 17 commits into from Feb 7, 2022
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 29, 2021

πŸ”— Linked issue

nuxt/nuxt#12909

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We should consider whether we want to support the use case in the linked issue, although the PR is safe to merge and likely a good idea.

Note: vite and rollup themselves are not yet compatible with resolved ids containing ' so even with this PR, the original issue is not solved.

πŸ“ Checklist

@danielroe danielroe added the bug Something isn't working label Nov 29, 2021
@danielroe danielroe requested a review from pi0 November 29, 2021 13:00
@danielroe danielroe self-assigned this Nov 29, 2021
@netlify
Copy link

netlify bot commented Nov 29, 2021

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: 5090279

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/62011f624917db00083ef739

@pi0
Copy link
Member

pi0 commented Nov 29, 2021

This seems nice initiative and refactors anyway even until rollup is not supporting πŸ‘ But I guess we should move this fix to mlly for generation utils and refactor once.

@pi0
Copy link
Member

pi0 commented Dec 20, 2021

@danielroe Would you please help resolving merge conflicts?

@danielroe
Copy link
Member Author

Current status is we are creating a new library in unjs namespace to host these utils.

I suggest I wait to resolve merge conflicts until we have that repo created or a PR open in it.

@danielroe danielroe mentioned this pull request Jan 26, 2022
1 task
@danielroe danielroe marked this pull request as ready for review January 28, 2022 17:00
@danielroe danielroe added the πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage label Jan 28, 2022
@danielroe
Copy link
Member Author

@pi0 It would be good to get this merged in even if we still have upstream issues with vite to resolve. (Unless you think there's something else we should fix here?)

@pi0 pi0 merged commit 29171bd into main Feb 7, 2022
@pi0 pi0 deleted the fix/sanitize-imports branch February 7, 2022 13:45
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants