fix(nuxi): always override NODE_ENV (#5417)

nuxt · Jun 12, 2022 · a9c061c · a9c061c · ennioVisco · Jun 12, 2022
1 parent 0f4fa56
commit a9c061c
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/packages/nuxi/src/commands/analyze.ts b/packages/nuxi/src/commands/analyze.ts
@@ -5,6 +5,7 @@ import { listen } from 'listhen'
 import { writeTypes } from '../utils/prepare'
 import { loadKit } from '../utils/kit'
 import { clearDir } from '../utils/fs'
+import { overrideEnv } from '../utils/env'
 import { defineNuxtCommand } from './index'
 
 export default defineNuxtCommand({
@@ -14,7 +15,7 @@ export default defineNuxtCommand({
     description: 'Build nuxt and analyze production bundle (experimental)'
   },
   async invoke (args) {
-    process.env.NODE_ENV = process.env.NODE_ENV || 'production'
+    overrideEnv('production')
 
     const rootDir = resolve(args._[0] || '.')
     const statsDir = join(rootDir, '.nuxt/stats')

diff --git a/packages/nuxi/src/commands/build.ts b/packages/nuxi/src/commands/build.ts
@@ -3,6 +3,7 @@ import consola from 'consola'
 import { writeTypes } from '../utils/prepare'
 import { loadKit } from '../utils/kit'
 import { clearDir } from '../utils/fs'
+import { overrideEnv } from '../utils/env'
 import { defineNuxtCommand } from './index'
 
 export default defineNuxtCommand({
@@ -12,7 +13,8 @@ export default defineNuxtCommand({
     description: 'Build nuxt for production deployment'
   },
   async invoke (args) {
-    process.env.NODE_ENV = process.env.NODE_ENV || 'production'
+    overrideEnv('production')
+
     const rootDir = resolve(args._[0] || '.')
 
     const { loadNuxt, buildNuxt } = await loadKit(rootDir)

diff --git a/packages/nuxi/src/commands/dev.ts b/packages/nuxi/src/commands/dev.ts
@@ -8,6 +8,7 @@ import { showBanner } from '../utils/banner'
 import { writeTypes } from '../utils/prepare'
 import { loadKit } from '../utils/kit'
 import { importModule } from '../utils/cjs'
+import { overrideEnv } from '../utils/env'
 import { defineNuxtCommand } from './index'
 
 export default defineNuxtCommand({
@@ -17,7 +18,7 @@ export default defineNuxtCommand({
     description: 'Run nuxt development server'
   },
   async invoke (args) {
-    process.env.NODE_ENV = process.env.NODE_ENV || 'development'
+    overrideEnv('development')
 
     const { listen } = await import('listhen')
     let currentHandler

diff --git a/packages/nuxi/src/utils/env.ts b/packages/nuxi/src/utils/env.ts
@@ -0,0 +1,8 @@
+export const overrideEnv = (targetEnv: string) => {
+  const currentEnv = process.env.NODE_ENV
+  if (currentEnv && currentEnv !== targetEnv) {
+    console.warn(`Changing \`NODE_ENV\` from \`${currentEnv}\` to \`${targetEnv}\`.`)
+  }
+
+  process.env.NODE_ENV = targetEnv
+}