Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate to vite 3 #480

Merged
merged 12 commits into from Sep 26, 2022
Merged

feat!: migrate to vite 3 #480

merged 12 commits into from Sep 26, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Aug 12, 2022

πŸ”— Linked issue

resolves #492

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR upgrades Bridge to Vite 3.

There are quite a few fixes/refactors to note, including some other vite fixes in Nuxt 3 that we're hereby porting back to Bridge. But particularly worth observing:

  1. We remove the workaround where we move build output files around, instead modifying chunk names.

  2. We remove our runtime URL implementation, using new Vite support from feat: experimental.buildAdvancedBaseOptionsΒ vitejs/vite#8450.

    We'll track the development of this feature quite closely as it moves from experimental into the mainstream, but it will not break in a minor version so the current version constraint is safe.

πŸ‘‰ Migration

Vite 3 is a major release with its own breaking changes. Users should read through the migration guide and make any updates necessary. (Other libraries may also have to be updated to work with Vite 3.)

There are no Nuxt-specific changes that users will need to make.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Aug 12, 2022
@danielroe danielroe self-assigned this Aug 12, 2022
@danielroe danielroe changed the title feat: migrate to vite 3 feat!: migrate to vite 3 Aug 12, 2022
@danielroe danielroe marked this pull request as ready for review August 16, 2022 18:50
@danielroe danielroe force-pushed the feat/vite-3 branch 2 times, most recently from a930229 to 2eb1466 Compare August 17, 2022 14:47
@danielroe
Copy link
Member Author

@pi0 - note stub fix for now - please do let me know if you have a better idea.

@danielroe danielroe merged commit 990b28d into main Sep 26, 2022
@danielroe danielroe deleted the feat/vite-3 branch September 26, 2022 14:49
@pi0 pi0 mentioned this pull request Apr 13, 2022
2 tasks
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bridge-vite: fonts are wrongly duplicating after build
1 participant