Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin): consider content as object #672

Merged
merged 10 commits into from May 15, 2023
Merged

fix(vite-plugin): consider content as object #672

merged 10 commits into from May 15, 2023

Conversation

ineshbose
Copy link
Collaborator

@ineshbose ineshbose commented May 9, 2023

makes progress for #671
also closes #630 and closes #673

It was odd that the minimatch bug didn't come up before f536b0d (probably due to build.externals), but I've swapped it with micromatch as it seems that it comes bundled with tailwindcss and even fast-glob.

src/hmr.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

Atinux commented May 9, 2023

Ping me when ready to review!

@ineshbose ineshbose marked this pull request as ready for review May 10, 2023 23:59
@ineshbose ineshbose requested a review from Atinux May 10, 2023 23:59
@Atinux Atinux merged commit 59246cf into nuxt-modules:main May 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module not working over stackblitz extraModules is not iterable error
2 participants