Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove unsed locales #57

Merged
merged 7 commits into from Mar 29, 2021
Merged

Conversation

ricardogobbosouza
Copy link
Member

Resolve #54

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #57 (dbba958) into master (885ea2c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           18        16    -2     
  Branches         6         4    -2     
=========================================
- Hits            18        16    -2     
Impacted Files Coverage Δ
lib/module.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 885ea2c...dbba958. Read the comment docs.

@ChangJoo-Park
Copy link

ChangJoo-Park commented Mar 26, 2021

It doesn't treeshake locale 😭

Result of webpack bundle analyzer

@ChangJoo-Park
Copy link

ChangJoo-Park commented Mar 26, 2021

latest version of date-fns has treeshaking probelm. Do you know date-fns/date-fns#2207 ?

also, Can you check my repo? https://github.com/ChangJoo-Park/date-fns-module/tree/feat-remove-unused-locales-issue-57

@ricardogobbosouza
Copy link
Member Author

Hi @ChangJoo-Park
Please try again
Its works now 😄

@ChangJoo-Park
Copy link

ChangJoo-Park commented Mar 26, 2021

It works!

Result of webpack bundle analyzer

@ricardogobbosouza ricardogobbosouza merged commit 8a1673b into master Mar 29, 2021
@ricardogobbosouza ricardogobbosouza deleted the feat-remove-unsed-locales branch March 29, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treeshaking of Locales
2 participants