Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump axios from 0.20.0 to 0.21.0 #436

Closed
wants to merge 1 commit into from
Closed

bump axios from 0.20.0 to 0.21.0 #436

wants to merge 1 commit into from

Conversation

suruaku
Copy link

@suruaku suruaku commented Oct 28, 2020

Closes #419

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files           1        1           
  Lines          45       45           
  Branches       25       25           
=======================================
  Hits           43       43           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8a53c...190c63e. Read the comment docs.

@mathieutu
Copy link
Contributor

@pi0 Could we merge and release this one? All delete calls are broken.

Thanks!

@sunecosuri
Copy link

@pi0
Is there anything I can do to merge this?
Due to a Delete request glitch, I would like to see this change made public.

Thank you,

@simllll
Copy link
Contributor

simllll commented Nov 14, 2020

Even if it seems semver should cover this, the problem here is that axios is still an <1.0 release, therefore every minor is counted as "breaking change", and npm does not install 0.21 even when the dependecies is defined "axios": "^0.20.0".

Also looking forward to this be released! Having issues with weird typescript definitions as there are several versions of axios now in my node modules

@jakubm95
Copy link

jakubm95 commented Nov 30, 2020

@pi0
When can we expect this update?

Thank you!

@pi0
Copy link
Member

pi0 commented Nov 30, 2020

Merged by #410 and updated with v5.12.3

Sorry for delay. I didn't notice since indeed axios is not following semver for fixes (it had to be 0.20.1)

Also a tip: If using yarn, it is possible to use resolutions field to force update a dependency.

@pi0 pi0 closed this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$axios.$delete body payload is missing
6 participants