Upgraded python 3.9.5 to 3.12.3 #4850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @gitofanindya - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
nxdrive/__main__.py
Outdated
| @@ -37,8 +37,8 @@ def main() -> int: | |||
|
|
|||
| try: | |||
| # XXX_PYTHON | |||
| if sys.version_info < (3, 9, 1): | |||
| raise RuntimeError(f"{APP_NAME} requires Python 3.9.1+") | |||
| if sys.version_info < (3, 12, 3): | |||
There was a problem hiding this comment.
suggestion (code_refinement): Check for potential breaking changes or deprecated features in Python 3.12.
Review the Python 3.12 release notes to ensure no deprecated features are being used that could affect the application's functionality.
Suggested change
| if sys.version_info < (3, 12, 3): | |
| import warnings | |
| if sys.version_info < (3, 12, 3): | |
| raise RuntimeError(f"{APP_NAME} requires Python 3.12.3+") | |
| else: | |
| # Check for deprecated Python features in 3.12 that may affect the application | |
| if sys.version_info[:2] == (3, 12): | |
| warnings.warn("Check Python 3.12 release notes for deprecated features.") |
| @@ -52,7 +52,7 @@ Executing the script without argument will setup.update the isolated environment | |||
|
|
|||
| [//]: # (XXX_PYTHON, XXX_INNO_SETUP) | |||
|
|
|||
| - [Python 3.9.5](https://www.python.org/ftp/python/3.9.5/python-3.9.5.exe). | |||
| - [Python 3.12.3](https://www.python.org/ftp/python/3.12.3/python-3.12.3.exe). | |||
There was a problem hiding this comment.
suggestion (code_clarification): Update documentation to reflect new Python version requirements.
Ensure all references in the documentation consistently reflect the upgrade to Python 3.12.3 to avoid confusion.
Suggested change
| - [Python 3.12.3](https://www.python.org/ftp/python/3.12.3/python-3.12.3.exe). | |
| [Python 3.12.3](https://www.python.org/downloads/release/python-3123/) |
gitofanindya
force-pushed
the
Upgrade-Python
branch
3 times, most recently
from
ec3aba7
to
c53a003
Compare
gitofanindya
force-pushed
the
Upgrade-Python
branch
from
c53a003
to
6e92012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded python 3.9.5 to 3.12.3