New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXDRIVE-2923: Download nuxeo package from nexus sonatatype #4839
base: master
Are you sure you want to change the base?
NXDRIVE-2923: Download nuxeo package from nexus sonatatype #4839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @swetayadav1 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
docs/changes/5.5.0.md
Outdated
- Check Drive version in Windows `ndrive.exe --version > version.txt` and then run `type version.txt` | ||
- Pointed MacOS pipeline from `macos-latest` to `macos-12` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code_clarification): Clarify the reason for MacOS pipeline version pinning.
It would be beneficial to include a brief explanation or rationale for pinning the MacOS pipeline to a specific version, as this could impact future maintenance or compatibility.
- Pointed MacOS pipeline from `macos-latest` to `macos-12` | |
Pointed MacOS pipeline from `macos-latest` to `macos-12` to ensure consistent build environments and avoid potential issues with future macOS updates that could introduce breaking changes. |
No description provided.