-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXDRIVE-2899: Display new workflow feature on features tab #4793
NXDRIVE-2899: Display new workflow feature on features tab #4793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @swetayadav1 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
nxdrive/gui/application.py
Outdated
if Feature.tasks_management: | ||
self.workflow = self.init_workflow() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code_refinement): Consider adding an else clause for when tasks management is disabled.
It might be beneficial to handle the scenario where tasks management is disabled, perhaps by setting a default or null workflow, to ensure consistent behavior across different feature configurations.
if Feature.tasks_management: | |
self.workflow = self.init_workflow() | |
if Feature.tasks_management: | |
self.workflow = self.init_workflow() | |
else: | |
self.workflow = None |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## wip-NXDRIVE-2889-Display-notification-for-document-review #4793 +/- ##
============================================================================================
Coverage ? 48.71%
============================================================================================
Files ? 95
Lines ? 15802
Branches ? 0
============================================================================================
Hits ? 7698
Misses ? 8104
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…es-tab' of https://github.com/nuxeo/nuxeo-drive into wip-NXDRIVE-2899-Display-new-workflow-feature-on-features-tab
…ew' of https://github.com/nuxeo/nuxeo-drive into wip-NXDRIVE-2899-Display-new-workflow-feature-on-features-tab
b254c53
into
wip-NXDRIVE-2889-Display-notification-for-document-review
* NXDRIVE-2889: Display system notification for document review * NXDRIVE-2899: Display new workflow feature on features tab (#4793)
NXDRIVE-2899: Display new workflow feature on features tab