Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2899: Display new workflow feature on features tab #4793

Conversation

swetayadav1
Copy link
Collaborator

@swetayadav1 swetayadav1 commented Apr 15, 2024

NXDRIVE-2899: Display new workflow feature on features tab

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @swetayadav1 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Comment on lines 222 to 223
if Feature.tasks_management:
self.workflow = self.init_workflow()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Consider adding an else clause for when tasks management is disabled.

It might be beneficial to handle the scenario where tasks management is disabled, perhaps by setting a default or null workflow, to ensure consistent behavior across different feature configurations.

Suggested change
if Feature.tasks_management:
self.workflow = self.init_workflow()
if Feature.tasks_management:
self.workflow = self.init_workflow()
else:
self.workflow = None

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (wip-NXDRIVE-2889-Display-notification-for-document-review@9baee8a). Click here to learn what that means.

❗ Current head 34e2187 differs from pull request most recent head 2d58921. Consider uploading reports for the commit 2d58921 to get more accurate results

Files Patch % Lines
nxdrive/gui/application.py 0.00% 8 Missing ⚠️
nxdrive/poll_workers.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@                                     Coverage Diff                                      @@
##             wip-NXDRIVE-2889-Display-notification-for-document-review    #4793   +/-   ##
============================================================================================
  Coverage                                                             ?   48.71%           
============================================================================================
  Files                                                                ?       95           
  Lines                                                                ?    15802           
  Branches                                                             ?        0           
============================================================================================
  Hits                                                                 ?     7698           
  Misses                                                               ?     8104           
  Partials                                                             ?        0           
Flag Coverage Δ
functional 38.11% <15.38%> (?)
unit 35.73% <15.38%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swetayadav1 swetayadav1 changed the base branch from wip-NXDRIVE-2889-Display-notification-for-document-review to wip-NXDRIVE-2873-Handle-workflow-in-drive April 16, 2024 05:58
@swetayadav1 swetayadav1 changed the base branch from wip-NXDRIVE-2873-Handle-workflow-in-drive to wip-NXDRIVE-2889-Display-notification-for-document-review May 16, 2024 09:31
@swetayadav1 swetayadav1 merged commit b254c53 into wip-NXDRIVE-2889-Display-notification-for-document-review May 16, 2024
18 of 20 checks passed
@swetayadav1 swetayadav1 deleted the wip-NXDRIVE-2899-Display-new-workflow-feature-on-features-tab branch May 16, 2024 12:25
swetayadav1 added a commit that referenced this pull request May 20, 2024
* NXDRIVE-2889: Display system notification for document review

* NXDRIVE-2899: Display new workflow feature on features tab (#4793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant