New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Laravel compatibility changes #1591

Closed

voydz wants to merge 1 commit into nuwave:4.x from voydz:patch-1

voydz commented Oct 20, 2020 •

edited

Added or updated tests
Documented user facing changes
Updated CHANGELOG.md

Resolves #1590

Changes

Changed method signature of LighthouseServiceProvider#loadRoutesFrom to match Laravel 8.11.x after [8.x] Change loadRoutesFrom to accept group $attributes laravel/framework#34866

Breaking changes

None

EDIT: PLEASE NOTE After some discussion in laravel/framework#34866 (comment) the change was reverted in laravel/framework@7fff6ea.


          Implemented Laravel compatibility changes

482e257

Author

voydz commented Oct 20, 2020

I would love to resolve the StyleCI issues but I have to admit, that I am not quite sure what its problem is.

spawnia closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment