Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update golang.org/x/sys to support go1.18 build #139

Merged
merged 1 commit into from Apr 7, 2022

Conversation

ag9920
Copy link
Contributor

@ag9920 ag9920 commented Apr 7, 2022

Currently go build/test will fail if you're using Golang 1.18. Here's the output:

# golang.org/x/sys/unix
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20181221143128-b4a75ba826a6/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20181221143128-b4a75ba826a6/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20181221143128-b4a75ba826a6/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20181221143128-b4a75ba826a6/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20181221143128-b4a75ba826a6/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20181221143128-b4a75ba826a6/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20181221143128-b4a75ba826a6/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20181221143128-b4a75ba826a6/unix/zsyscall_darwin_amd64.go:136:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20181221143128-b4a75ba826a6/unix/zsyscall_darwin_amd64.go:151:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20181221143128-b4a75ba826a6/unix/zsyscall_darwin_amd64.go:166:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20181221143128-b4a75ba826a6/unix/zsyscall_darwin_amd64.go:166:3: too many errors
FAIL    github.com/xujiajun/nutsdb [build failed]

This was caused by an old version of golang.org/x/sys (mentioned in this issue).

This PR simply update golang.org/x/sys to support go1.18. I've already test it locally.

@xujiajun xujiajun merged commit 5efcfe5 into nutsdb:master Apr 7, 2022
@xujiajun xujiajun mentioned this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants