Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hot-reload for server side #1108

Merged
merged 1 commit into from Aug 26, 2018
Merged

Add hot-reload for server side #1108

merged 1 commit into from Aug 26, 2018

Conversation

li-kai
Copy link
Member

@li-kai li-kai commented Aug 25, 2018

Implements "hot-reload" via webpack. Right now it technically closes off all requests and sockets and restarts.

Hopefully apollographql/apollo-server#1275 resolves and there will be a better solution. This will do for now.

Also, this opens up the opportunity for ssr. 馃暫

@li-kai li-kai requested a review from a team August 25, 2018 17:52
Copy link
Member

@taneliang taneliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we can't do easily in Rails 馃帀

@li-kai li-kai force-pushed the apollo-server-2 branch 2 times, most recently from 8e1b004 to 391a416 Compare August 26, 2018 06:57
@li-kai li-kai changed the base branch from apollo-server-2 to master August 26, 2018 07:42
@mods-bot
Copy link

mods-bot commented Aug 26, 2018

Deploy preview for nusmods ready!

Built with commit ed167b3

https://deploy-preview-1108--nusmods.netlify.com

@li-kai li-kai merged commit bd3a1ba into master Aug 26, 2018
@li-kai li-kai deleted the hot-reload-api-server branch August 26, 2018 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants