New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepend directory to the binary tarball #6701
Conversation
According to https://www.gnu.org/software/tar/manual/html_section/transform.html, use `--transform` parameter to prepend directory to each file name. Closes nushell#6676
Do we have any consumers of our tarballs that might need adjustment with this change? |
Nope, as @christianhujer said, the tar archive usually contains a directory. |
I am wondering if we need to change things for downstream tools or package distributors that download the nu binaries from the GitHub release. Examples: |
|
No change from my perspective. Ansible role already searches recursively to find the files. With that said, the only reason I'm doing it in the first place is because tarball does not have the directory prepended to it. |
I'm nervous about this one because all downstream consumers might need to change something. |
Feel free to merge this PR, I will fix |
@fdncred maybe post about this change on discord/twitter/etc to reach other consumers, other than me and hustcer there are probably people maintaining packages in third party repos such as aur or pacstall |
This seems like a good idea to me. In general, Linux package managers are going to be building Nu from source and won't be affected by this. Homebrew builds from source too. |
Package managers yes, but places such as pacstall, aur, homebrew etc that automate the process of downloading the release from github might be affected |
Homebrew builds Nu from scratch. I believe AUR does too. I understand that some tools might use our binaries but I suspect the number of such tools is quite small. |
let's move forward with this. I just hope it doesn't come back to bite us on Nov 8th release. Thanks! |
|
Looks like this ended up breaking virtualenv. Hopefully they can work around it. pypa/virtualenv#2442 (comment) |
Description
According to https://www.gnu.org/software/tar/manual/html_section/transform.html, use--transform
parameter to prepend directory to each file name.GNU tar is not available on Mac by default, use a common way.
Closes #6676
Tests
Make sure you've done the following:
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --check
to check standard code formatting (cargo fmt --all
applies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
to check that you're using the standard code stylecargo test --workspace --features=extra
to check that all the tests pass