neither hide nor hide-env seems to hide environment variables from externals

[fdncred]

Describe the bug

I'm trying to hide an environment variable from externals, specifically cargo.

How to reproduce

1. hide CARGO_TARGET_DIR
2. hide-env CARGO_TARGET_DIR
3. $env.CARGO_TARGET_DIR produces the error it should
4. ^env show that CARGO_TARGET_DIR is still set
5. cargo build, puts all build artifacts in the CARGO_TARGET_DIR folder

Expected behavior

Externals shouldn't see a hidden env var

Screenshots

No response

Configuration

key	value
version	0.75.1
branch	main
commit_hash	5e957ec
build_os	windows-x86_64
build_target	x86_64-pc-windows-msvc
rust_version	rustc 1.66.1 (90743e729 2023-01-10)
rust_channel	1.66.1-x86_64-pc-windows-msvc
cargo_version	cargo 1.66.1 (ad779e08b 2023-01-10)
pkg_version	0.75.1
build_time	2023-02-01 08:23:51 -06:00
build_rust_channel	release
features	database, dataframe, default, trash, which, zip
installed_plugins	custom-value generate

Additional context

No response

[refl3ction]

Any updates?

[fdncred]

I think I've narrowed it down to this line returning None. Now to figure out what to do about it.

nushell/crates/nu-protocol/src/engine/stack.rs

Lines 326 to 327 in f4bd78b

	self.env_hidden
	.insert(active_overlay.into(), HashSet::from([name.into()]));

[kubouch]

@fdncred What is the output of your overlay list at the time you're calling the hide-env?

[fdncred]

@fdncred What is the output of your overlay list at the time you're calling the hide-env?

╭───┬──────╮
│ 0 │ zero │
╰───┴──────╯

[fdncred]

I only use this env var on Windows and on Windows by default shell is pwsh. CARGO_TARGET_DIR is set the regular way you set env vars in Windows. I can't remember right now if it's in HKLM or HKCU. But I'm wondering if it has something to do with having a parent shell and inheriting those env vars?

[fdncred]

I can reproduce it on my mac too like this.

In fish:

> echo $COLORTERM
truecolor

start nushell

> $env.COLORTERM
truecolor

now do this

> hide-env COLORTERM
> $env.COLORTERM
Error: nu::shell::column_not_found (link)

  × Cannot find column
   ╭─[entry #5:1:1]
 1 │ $env.COLORTERM
   · ──┬─ ────┬────
   ·   │      ╰── cannot find column 'COLORTERM'
   ·   ╰── value originates here
   ╰────
> ^env 
CMD_DURATION_MS=1
COLORTERM=truecolor

[kubouch]

Yeah, it might be the inherited env vars... I thought it had to do with multiple overlays but couldn't reproduce it and since you have only one, the problem will be somewhere else.

[kubouch]

What is truecolor?

[fdncred]

it's an env var that some *nix terminals need to support 24-bit color vs 8-bit.

[fdncred]

similar to #6593 but different examples.