Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nushell can't hide venv after hide-env VIRTUAL_ENV #4386

Open
gotounix opened this issue Sep 20, 2022 · 3 comments
Open

Nushell can't hide venv after hide-env VIRTUAL_ENV #4386

gotounix opened this issue Sep 20, 2022 · 3 comments
Labels
🐛 bug Something isn't working as expected. 🌊 upstream Depends on an upstream solve beyond starship

Comments

@gotounix
Copy link

gotounix commented Sep 20, 2022

Bug Report

Current Behavior

Nushell can't hide venv after hide-env VIRTUAL_ENV.

And while using virtualenv, after deactivate the Python version will display all time in this terminal tab.

Expected Behavior

Hide venv after hide-env VIRTUAL_ENV

Additional context/Screenshots

1663664489092

1663665581797

Possible Solution

Environment

  • Starship version: [1.10.3]
  • Shell type: [nushell]
  • Shell version: [0.68.1]
  • Shell plugin manager: [if present, e.g. oh-my-fish, oh-my-zsh, fisher, antigen]
  • Terminal emulator: [Windows Terminator]
  • Operating system: [Windows 10]

Relevant Shell Configuration

# Your configuration here

Starship Configuration

# Your configuration here
@gotounix gotounix added the 🐛 bug Something isn't working as expected. label Sep 20, 2022
@davidkna
Copy link
Member

Thanks for creating a bug report!

If starship still displays the virtual env name, it must means the external starship binary is still being started with the old value. The behavior of (environment) variables in nushell can be non-intuitive. Please try reporting your issue upstream.

@davidkna davidkna added the 🌊 upstream Depends on an upstream solve beyond starship label Sep 20, 2022
@andytom
Copy link
Member

andytom commented Jan 1, 2023

I think this might have been fixed by pypa/virtualenv#2422 but I am not a nu shell user so can't confirm. Is this still an issue with the most recent versions of nu shell and virtualenv activation script?

@andytom
Copy link
Member

andytom commented Apr 2, 2024

The original upstream issue was closed as a duplicate the new one this issue is tracking is nushell/nushell#7937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working as expected. 🌊 upstream Depends on an upstream solve beyond starship
Projects
None yet
Development

No branches or pull requests

3 participants