Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ESC[22m to reset bold and dim #55

Closed
wants to merge 1 commit into from

Conversation

@rsteube
Copy link
Author

rsteube commented Jan 3, 2024

Updated the test but have not verified it. Someone needs to confirm that adding this is fine.

@fdncred
Copy link

fdncred commented Jan 3, 2024

This doesn't seem correct to me. Reset is just 0m not 0;22m. 0m should reset everything, all styles and colors, right? I thought 22m was just to reset bold and leave everything else alone.

@rsteube
Copy link
Author

rsteube commented Jan 3, 2024

I expected that as well but in the completion menu, which uses RESET, bold is kept:

image

This is pretty much a test to see if it would fix it, but I can't get the dependency replacement to work.
Probably something else that causes it, I got a bit irritated by the ansi documentation and a related issue I had with powershell.

@rsteube
Copy link
Author

rsteube commented Jan 3, 2024

Closing this, a simple test with echo is fine. Sorry about this, think I need some sleep 😅 .

@rsteube rsteube closed this Jan 3, 2024
@rsteube rsteube deleted the reset-bold branch January 3, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants