Make Style.with_reset more explicit as prefix_with_reset
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the behavior is probably a bit unclear and everybody constructing or destructuring it by hand will now have to take this field into account we should be as explicit as possible. @fdncred 's suggestion was `prefix_with_reset`. I also tried to be even more detailed in the fields docstring for anybody interacting it after `0.47.0`. @alexkunde check me if I am wrong here.
|
hi @sholderbach yes, if you use the struct without ..default() you will run into a breaking change. |
|
I'd vote for later. We're about to make a nushell release on the 25th and I'd love for it to have the latest nu-ansi-term. That doesn't leave a lot of time to code and test. If it's trivial then it's no big deal though. |
|
Looking at the timeline, I would than also vote for later, as I dont really have time this weekend to look into the matter. Even without reset colors this PR is a very good step forward! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the behavior is probably a bit unclear and everybody constructing or
destructuring it by hand will now have to take this field into account
we should be as explicit as possible. @fdncred 's suggestion was
prefix_with_reset.I also tried to be even more detailed in the fields docstring for
anybody interacting it after
0.47.0. @alexkunde check me if I am wronghere.