feat(DeviceSettings): info alert with a link to the documentation #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the user to quickly find what are the settings options for. I personally was looking for what is "Disabled" option actually doing. The info icon generated using: * https://getbootstrap.com/docs/5.0/components/alerts/#icons * https://icons.getbootstrap.com/icons/info-circle-fill/
prettier --check -w "./**/*.{js,jsx,tsx}"
MacDada
commented
May 11, 2024
Centering vertically (perfectionist hell :D)
MacDada
force-pushed
the
settings_docs_info
branch
from
06b2fda
to
080e707
Compare
`prettier --check "./**/*.{js,jsx,tsx}" -w`
fixes https://github.com/nurikk/zigbee2mqtt-frontend/actions/runs/9082225515/job/24958031689
I actually think it's more readable with the code being split into multiply lines…
Not sure why the `prettier` did not like it ;p
nurikk-sa
reviewed
May 16, 2024
|
Terrific job! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link to the docs allows the user to quickly find what are the settings options for.
I personally was looking for what is "Disabled" option actually doing.
I wasn't sure how to style it -> if there is a better (maybe some kind of "standard") way of injecting this kind of info alerts, I will happily improve the PR :-)