fix(ComposerLoader): use full load to avoid that when using composer/composer ^2.3 a PartialComposer is returned #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DannyvdSluijs
force-pushed
the
fix-565
branch
from
acfcb5a
to
bf8beac
Compare
…composer ^2.3 a PartialComposer is returned This is a simple fix in an attempt to get the package working when minimum-stability is set to "dev" in composer.json and doesnt address input from Jordi Boggiano in nunomaduro#559
DannyvdSluijs
force-pushed
the
fix-565
branch
from
bf8beac
to
8dd0df5
Compare
|
Hello @DannyvdSluijs , I just tried this change locally and it seemed to work! PS: you might want to mention one of this repo's maintainers to bring their attention to this PR. I don't think they get notifications when a PR is created, but I could be wrong 😄 |
|
@nunomaduro there is a confirmation of the fix. Would you mind approving the automerk checks so we have that feedback as well? |
|
@nunomaduro Please merge it to make it usable in Laravel 9. |
|
it’s works! |
giraz82
approved these changes
Mar 7, 2022
bvlinsky
approved these changes
Mar 7, 2022
Shadow38PL
approved these changes
Mar 7, 2022
BrandonOldenhof
approved these changes
Mar 7, 2022
|
@DannyvdSluijs thanks for your contribution! I've also verified this works in Laravel 8 and 9 |
This was referenced Mar 8, 2022
Teakowa
added a commit
to XNXKTech/laravel-esign
that referenced
this pull request
Mar 21, 2022
This commit will fix nunomaduro/phpinsights#565 error, it's came from nunomaduro/phpinsights#566 , and this commit will also switch the target version to dev-master, since the upstream repository has not yet released a version, This will last for some time. Signed-off-by: Teakowa Gatanothor O'deorain <hub+git@teakowa.dev>
|
Is it possible to create a release for this fix? |
|
Just tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix in an attempt to get the package working when minimum-stability is set to "dev" in composer.json and doesnt address input from Jordi Boggiano in #559