fix: make, makeWith and resolve methods not resolving to correct type on Application and Container.

[mad-briller]

• Added or updated tests
• Documented user facing changes
• Updated CHANGELOG.md

resolves #1441

Changes
Added return type extension for Application and Container make, makeWith and resolves method.

Abstracts repeated behavior into a AppMakeHelper and uses that in places i could find it being duplicated.

[mad-briller]

it's not really guaranteed that resolve will return an object, scalars can be bound into the container using constant string names too and i've seen that in the wild, so it might be worth expanding this code to anticipate more types to be returned in the future

[mad-briller]

not sure that the koel/koel e2e failures are caused by this change

[JanMikes]

Hi, i have checked the failing E2E test and actually this is correct that test is failing.

https://github.com/koel/koel/blob/master/tests/Traits/CreatesApplication.php#L25

    use App\Console\Kernel;
    use Illuminate\Contracts\Console\Kernel as Artisan;

    private Kernel $artisan;

    $this->artisan = $app->make(Artisan::class);

Because this PR adds phpstan functionality that makes it understand that $app->make(Artisan::class) will return instance of Artisan (the interface) and the property is typed to specific implementation.

I will try send a PR to fix this issue in original repo.

[mad-briller]

@canvural is there anything i can do to help get this over the line? thanks

[JanMikes]

Pls can you re-run the E2E pipeline? Should be passing now.

[szepeviktor]

Pls can you re-run the E2E pipeline?

Here you go. This is the rerun.
https://github.com/nunomaduro/larastan/actions/runs/3684486433/jobs/6280772909

[JanMikes]

I see - though the dependent PR is merged, there is fixed git reference: https://github.com/nunomaduro/larastan/blob/master/.github/workflows/e2e-tests.yml#L40

We would need to change it to 9e864c937f5f060aa0192596d4e0776e68dc16e5 (references to koel/koel@9e864c9)

[canvural]

Thank you!