fix: Added CreatesApplication strict typing

[JanMikes]

See larastan/larastan#1451 (comment)

[phanan]

Thanks, but E2E isn't failing because of this (which actually I'm not sure what it is TBH). It's failing because I don't have time yet to adapt it to the vue 3 rewrite.

[JanMikes]

Hi, thank you for your reply.

Maybe we misunderstood each other - E2E tests of larastan are failing and it has nothing to do with vue 3 rewrite: https://github.com/nunomaduro/larastan/actions/runs/3684486433/jobs/6234278865

My change in this MR fixes this error:

 ------ -------------------------------------------------------------------------------------------------------------
  Line   tests/Traits/CreatesApplication.php (in context of class Tests\TestCase)
 ------ -------------------------------------------------------------------------------------------------------------
  23     Property Tests\TestCase::$artisan (App\Console\Kernel) does not accept Illuminate\Contracts\Console\Kernel.
 ------ -------------------------------------------------------------------------------------------------------------


 [ERROR] Found 1 error

This error is introduced with change in larastan - dynamic extension which makes phpstan understand return type of $this->app->make().

It is clear that the code in \Tests\Traits\CreatesApplication is trying to put interface type into variable with specific implementation type, which makes phpstan fail (correctly!).

private Kernel $artisan;

$this->artisan = $app->make(Artisan::class);

Adding assertion there, makes 100% sure (and phpstan understands) that $app->make(Artisan::class) returns Kernel:

$artisan = $app->make(Artisan::class);
assert($artisan instanceof Kernel);

$this->artisan = $artisan;

I tested everything locally and it works very well.

Can we please reopen and re-consider this MR? Thank you.

[JanMikes]

Other possible solution (and maybe more readable) would be to do this:

- $this->artisan = $app->make(Artisan::class);
+ $this->artisan = $app->make(Kernel::class);

But honestly i did not know what (and if any) was intention of getting Artisan::class from DI, so i kept it that way.

[phanan]

In such a case, wouldn't it be simpler to use type-hinting instead?

/** @var Kernel $artisan */
$artisan = $app->make(Artisan::class);

[JanMikes]

👍 This is alternative, as well possible way

[phanan]

…which I'd prefer, because it doesn't cost anything :) Would you mind revising the PR accordingly?

[codecov-commenter]

Codecov Report

Merging #1626 (113633c) into master (e8e2c2d) will not change coverage.
The diff coverage is n/a.

❗ Current head 113633c differs from pull request most recent head 7c666c5. Consider uploading reports for the commit 7c666c5 to get more accurate results

@@            Coverage Diff            @@
##             master    #1626   +/-   ##
=========================================
  Coverage     81.50%   81.50%           
  Complexity      654      654           
=========================================
  Files           151      151           
  Lines          1757     1757           
=========================================
  Hits           1432     1432           
  Misses          325      325           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[JanMikes]

Updated. Thank you for being open for this kind of improvements.

[phanan]

All good, thanks a lot!