Support PHPUnit version 8 identifier requirement #60
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pters\Phpunit\Listener' to instead ensure that version 7 is the required minimum, while future versions will be automatically accepted set author
ghost
mentioned this pull request
Closed
nunomaduro
requested changes
Feb 1, 2019
ghost
changed the base branch from
|
Done :) |
|
Thanks for this! |
|
@nunomaduro This should not be in develop branch anymore. Pulling |
|
@nunomaduro Agreed with @ludo237. Could you add phpunit 8 support to 2.1 version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the PHPUnit version requirement in 'NunoMaduro\Collision\Adapters\Phpunit\Listener' to instead ensure that version 7 is the required minimum, while future versions will be automatically accepted.
This fixes #59
I couldn't immediately determine an easy way to add a test for this functionality for a number of reasons: