Allows a custom Writer to be set on the PhpUnit adapter #193
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenvoke
approved these changes
Aug 25, 2021
|
@lukeraymonddowning @owenvoke you can release. |
|
Don't have permission to release on Collision. @owenvoke are you cool to do it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy Wednesday!
Up until now, the Writer on the PhpUnit Printer for Collision was instantiated by the class itself. For Pest parallel, we need to be able to set a custom writer that allows us to force the colour style in the highlighter to get syntax highlighting on test errors.
This PR add a new setStyleWriter method on the Printer, which allows for an override of the default writer.
Kind Regards,
Luke