Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUnit test adapter does not detect test cases that contain ")." in a string #1097

Open
icemanfresh opened this issue May 23, 2023 · 3 comments

Comments

@icemanfresh
Copy link

NUnit version: 3.13.3
NUnit3TestAdapter version: 4.4.2

Visual Studio 2022 Version 17.5.4

.NET 6.0

Description:
In Visual Studio, given an NUnit test case with a string that contains ").", such as the following:

[TestCase("I am a good test case (the best, even).")]

Test Explorer doesn't discover it.

@OsirisTerje
Copy link
Member

OsirisTerje commented May 30, 2023

@icemanfresh I've added a repro here: https://github.com/nunit/nunit3-vs-adapter.issues/tree/master/Issue1097
Running it shows it IS detected, but the naming of the test is mangled. The test itself works as it should.

image

If you have a version where the test is not discovered, please create a similar repro and upload it.

The name mangling is a bug though, but not sure if the adapter or the Microsoft Test Explorer is guilty here.

@icemanfresh
Copy link
Author

Oh yes, my teammates did some digging and they eventually found it under a different name, like what happened in your case. I'm not sure if the adapter is at fault either.

@OsirisTerje
Copy link
Member

Thanks! Then I keep it open as a name-mangling bug until we figure out where it originates :-)

OsirisTerje added a commit that referenced this issue May 30, 2023
OsirisTerje added a commit that referenced this issue May 30, 2023
* Added engine with fix for NUnit 4

* Updated test projects

* Updating to 4.5.0

* commented out local nuget feed

* resetting frameworks for test project

* Updateing target frameworks

* Fix for issue #1097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants