Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Discoverer reflection holds open file #10

Closed
CharliePoole opened this issue Apr 2, 2015 · 0 comments
Closed

Test Discoverer reflection holds open file #10

CharliePoole opened this issue Apr 2, 2015 · 0 comments
Assignees
@CharliePoole
Labels
closed:done is:bug pri:high
Milestone
3.0-ctp-1

Comments

@CharliePoole
Copy link
Contributor

NUnit3TestDiscoverer.IsNUnit3TestAssembly uses reflection to look at the references of the test assembly to determine whether it's an NUnit version 3 or greater assembly. Because the reflection is done in the same AppDomain, the assembly being examined is held open, preventing it's rebuilding.

The best resolution would be for the assembly to be examined in a separate AppDomain, which could then be unloaded.
@CharliePoole CharliePoole added this to the 3.0-ctp-1 milestone Apr 2, 2015
@CharliePoole CharliePoole self-assigned this Apr 2, 2015
rprouse added a commit that referenced this issue Apr 5, 2015
@rprouse
Merge pull request #11 from nunit/issue-10
20dea04 
Fix #10 - Test Discoverer reflection holds open file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharliePoole CharliePoole

Labels
closed:done is:bug pri:high
Projects
None yet
Milestone
3.0-ctp-1
Development

No branches or pull requests
1 participant
@CharliePoole