Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport tests from PR #4692 to 3.x #4708

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from

Conversation

stevenaw
Copy link
Member

@stevenaw stevenaw commented May 8, 2024

Backport tests from #4692
To verify the functionality from 3.x that we're restoring. Relates to #4598

This PR also switches the macos image on github actions to target specifically macos-12 in order to work around this NET5-related issue: dotnet/runtime#48068. It seems this may be the first time we're running CI on the 3.x branch since macos-latest was changed to macos-14 and the newer silicon architecture.

@stevenaw stevenaw marked this pull request as draft May 11, 2024 01:07
@stevenaw stevenaw force-pushed the v3-4598-timeout-context-output-snapshot branch from ef7f0d2 to 49cd8f8 Compare May 13, 2024 02:58
@stevenaw
Copy link
Member Author

@nunit/framework-team
I've noticed net5 tests still running on the 3.x branch are now failing on macos. That runtime has been EOL for a while and is no longer used in main. Any objections to me removing it from 3.x either within this PR or separately?

@OsirisTerje
Copy link
Member

OsirisTerje commented May 20, 2024

I believe we have stated that 3.X will continue to support these OOD frameworks.
Can't we just disable that test from MacOS, and make a note of it ?
I believe we do have some more of those, which have been marked the same way, I think using the Platform attribute.

@stevenaw
Copy link
Member Author

Thanks @OsirisTerje I can try to take a closer look.

@stevenaw
Copy link
Member Author

stevenaw commented May 20, 2024

Huh interesting. Thanks for having me take a closer look here @OsirisTerje
I had thought it was a NET5 EOL issue but the real thing here was that macos-latest switched to macos-14 which uses newer Apple Silicon / M1+. It appears this was a known issue a few years back with NET5 not working there in all cases: dotnet/runtime#48068

Switching the image from macos-latest down to macos-12 seems to have solved it. macos-12 is still supported and not yet deprecated based on https://github.com/actions/runner-images?tab=readme-ov-file.

I think this is ready to switch out of Draft

@stevenaw stevenaw marked this pull request as ready for review May 20, 2024 19:46
@OsirisTerje
Copy link
Member

@stevenaw Awesome! And agree!

Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants