Skip to content

BUG: Connect to earlier event #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2020
Merged

BUG: Connect to earlier event #269

merged 2 commits into from
Jun 27, 2020

Conversation

larsoner
Copy link
Collaborator

Closes #268.

Another option might be to still connect to build-inited but with a lower priority number, but in theory connecting to config-inited should be okay (and arguably cleaner anyway).

@jnothman
Copy link
Member

We currently have CI testing on Sphinx 1.6.5 which does not know config-inited. Do we end support for it (I suppose that's not the right thing to do in a patch release), or switch hooks for Sphinx <2

@larsoner
Copy link
Collaborator Author

I can just try/except for now and make a note that we should get rid of it once we bump our Sphinx requirement

@codecov-commenter
Copy link

Codecov Report

Merging #269 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   92.66%   92.70%   +0.03%     
==========================================
  Files           7        7              
  Lines        1255     1261       +6     
==========================================
+ Hits         1163     1169       +6     
  Misses         92       92              

Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good by me, but deserves confirmation from @arokem

@arokem
Copy link

arokem commented Jun 26, 2020

This works on my end. The master branch still raises the error mentioned in the issue, but with this branch installed, no error. Thanks!

@jnothman jnothman merged commit b352cd7 into numpy:master Jun 27, 2020
@jnothman
Copy link
Member

Thanks @larsoner and @arokem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants