MAINT: update x86-simd-sort to latest #26338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MSVC is failing to build |
yeah, MSVC has no icelake specific flags and doesn't define AVX512VBMI2 leading to missing header files :/ |
r-devulap
force-pushed
the
xss-static-api
branch
from
a477059
to
4045b72
Compare
|
Ci is passing. @seiko2plus want to take a look? |
Mousius
added
the
component: SIMD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latest version simplifies the use of static avx512 and avx2 sort, argsort, partition and argpartition functions. No difference in performance or algorithms.