DOC: Documentation and examples for conversion of np.timedelta64 units #26322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
reviewed
May 1, 2024
| Traceback (most recent call last): | ||
| File "<stdin>", line 1, in <module> | ||
| TypeError: Cannot cast scalar from dtype('<m8[M]') to dtype('<m8[D]') according to the rule 'safe' | ||
|
|
There was a problem hiding this comment.
I don't think these examples add anything useful, I would just delete everything from line 226 to here. The sentence you added above is enough to explain what's happening.
There was a problem hiding this comment.
Thank you so much for reviewing, I have made changes suggested.
|
Thanks @ajayjanapareddi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26121
Thank you for the anamzing work of numpy!
Added documentation and examples, explaining 'safe' and 'unsafe' casting behaviors (with astype) for the timedelta unit (month/year/day) conversions.
This is my first PR on numpy.
Kindly review.