New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Added display modes for show_runtime
#26255
Draft
ganesh-k13
wants to merge
3
commits into
numpy:main
Choose a base branch
from
ganesh-k13:show_runtime_modes
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganesh-k13
added a commit
to ganesh-k13/numpy
that referenced
this pull request
Apr 10, 2024
ganesh-k13
force-pushed
the
show_runtime_modes
branch
from
April 10, 2024 13:59
6e3b392
to
f1d6df9
Compare
ganesh-k13
added a commit
to ganesh-k13/numpy
that referenced
this pull request
Apr 10, 2024
ganesh-k13
force-pushed
the
show_runtime_modes
branch
from
April 10, 2024 14:02
f1d6df9
to
d55c7ce
Compare
Additionally created a util file for common functions between `show_config` and `show_runtime`
ganesh-k13
force-pushed
the
show_runtime_modes
branch
from
April 10, 2024 14:06
d55c7ce
to
52f335a
Compare
ganesh-k13
commented
Apr 10, 2024
@@ -633,7 +634,7 @@ test: PytestTester | |||
# | |||
# Placeholders for classes | |||
|
|||
def show_config() -> None: ... | |||
def show_config(mode: ConfigDisplayModes) -> None | dict: ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some tests?
The answer to that question is pretty much always "yes, if they are not slow and complicated"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
show_runtime
Allowed modes are same as
show_config
`dicts` mode
`stdout` mode (default)
ToDo
Notes
resolves: https://mail.python.org/archives/list/numpy-discussion@python.org/thread/NF7ET6O5ELCLXGEIN7P2AUO5S4MESMSK/