Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Exclude import libraries from list of DLLs on Cygwin. #24570

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

DWesl
Copy link
Contributor

@DWesl DWesl commented Aug 28, 2023

There are import libraries in numpy.random (with extension .dll.a) that are intended for distribution. The script to list DLLs on Cygwin should not include those, only actual DLLs.

See #24206 for the issue prompting this PR.

There are import libraries in numpy.random that are intended for distribution.   This script should not include those, only actual DLLs.
@charris
Copy link
Member

charris commented Aug 29, 2023

Looks good, but I am not clear on what the difference does. Could you add a bit of explanation?

@charris charris merged commit 0239d3e into numpy:main Aug 29, 2023
53 checks passed
@charris
Copy link
Member

charris commented Aug 29, 2023

Thanks @DWesl .

@DWesl
Copy link
Contributor Author

DWesl commented Aug 29, 2023

Import libraries, .dll.a on Cygwin and .lib on WIndows, seem to be a list of functions found in the corresponding shared library (.dll on both), which allows compilers to verify at link time that there is a definition for all symbols, which will be available at run time.

@DWesl DWesl deleted the patch-4 branch August 29, 2023 18:09
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants