BUG: Fix median and quantile NaT handling #23774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this doesn't mean that rounding is correct at least for quantiles, so there is some dubious about it being a good idea to use this. But, it does fix the issue, and I the `copyto` solution seems rather good to me, the only thing that isn't ideal is the `supports_nan` definition itself. Closes numpygh-20376
|
Thanks Sebastian. |
|
I marked this for backport although that might be risky. |
|
Hmmm, this bug has been around very long, lets just punt on backporting? |
|
You convinced me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this doesn't mean that rounding is correct at least for quantiles, so there is some dubious about it being a good idea to use this.
But, it does fix the issue, and I the
copytosolution seems rather good to me, the only thing that isn't ideal is thesupports_nandefinition itself.Closes gh-20376
I don't trust quantiles on times, because I don't trust the
time * floatmultiplication really (and probably more).But, maybe it's still OK to fix the NaT handling to make some sense... The fix tries to be minimal, but I feel the
DATA_AXIS = 0andtakedoesn't help.