Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Replace Python3.8 by Python3.9. #22902

Merged
merged 1 commit into from Jan 3, 2023
Merged

Conversation

charris
Copy link
Member

@charris charris commented Dec 29, 2022

We will drop Python3.8 in NumPy 1.25. This PR updates the ci tests and wheel builds to use 3.9.

A few observations in getting this working:

  • PyPy 3.9 isn't ready, it fails some tests, it is left at 3.8.
  • The latest cibuildwheel@v2.11.4 fails on 32 bit Windows, cibuildwheel@2.11.2 works.

The failing PyPy 3.9 tests aren't terrible, we could skip them, but I would rather not at this point.

After this goes in, I'll make another PR using cibuildwheel@v2.11.4 to generate errors so I can report them upstream. We will need this fixed so that later versions with Python 3.12 will work when we begin to support it.

@charris
Copy link
Member Author

charris commented Dec 29, 2022

I didn't touch Cygwin in this first trial. Let's what problems the other test have.

We will drop Python3.8 in NumPy 1.25. This PR  updates the ci tests and
wheel builds to use 3.9.
@charris
Copy link
Member Author

charris commented Dec 30, 2022

@seiko2plus Is the EXPECT_CPU_FEATURES environment variable still needed for the aarch64 builds? I moved it from the Python 3.8 build to the Python 3.9 build.

@seiko2plus
Copy link
Member

Is the EXPECT_CPU_FEATURES environment variable still needed for the aarch64 builds?

Just one build is needed to test the sanity of the infrastructure in case of any sudden changes lead to breaking the compile-time detection of CPU features.

Copy link
Member

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not merging for a bit in case anyone else had thoughts here.

@@ -12,7 +12,7 @@ jobs:
# therefore a new base image chose instead to guarantee to
# have a newer version >= 1.8.10 to avoid warnings
# that related to the default behaviors or non-exist config options
- image: cimg/base:2021.05
- image: cimg/python:3.9
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that python 3.10 and 3.11 are also available. I chose 3.9 as most likely to be compatible with our other documentation dependencies.

@seberg
Copy link
Member

seberg commented Jan 3, 2023

OK, lets just get it in, we can always follow up, thanks Chuck.

@seberg seberg merged commit 9f1b3ef into numpy:main Jan 3, 2023
@charris
Copy link
Member Author

charris commented Jan 3, 2023

@mattip Are you still working to get PyPy 3.9 up for NumPy?

@mattip
Copy link
Member

mattip commented Jan 3, 2023

I am waiting for cibuildwheel to release a version that supports pypy + macos + arm64, which is progessing in pypa/cibuildwheel#1372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants