New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix integer overflow in in1d for mixed integer dtypes #22877 #22878
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
54aa5bc
TST: Mixed integer types for in1d
MilesCranmer dbfdcbd
BUG: Fix mixed dtype overflows for in1d (#22877)
MilesCranmer f7a1439
BUG: Type conversion for integer overflow check
MilesCranmer c688977
MAINT: Fix linting issues in in1d
MilesCranmer 1d09d09
MAINT: ar1 overflow check only for non-empty array
MilesCranmer b7f1701
MAINT: Expand bounds of overflow check
MilesCranmer 96cd847
TST: Fix integer overflow in mixed boolean test
MilesCranmer c8299cb
TST: Include test for overflow on mixed dtypes
MilesCranmer c8499c6
MAINT: Less conservative overflow checks
MilesCranmer File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR also corrects the bounds of the overflow check. It should have really been
<=
in #12065, rather than<
. I noticed this after adding some new tests.