New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Better report integer division overflow (backport) #22230
Merged
charris
merged 12 commits into
numpy:maintenance/1.23.x
from
ganesh-k13:backport_bug_div_overflow_1_23
Sep 8, 2022
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d31240e
BUG, SIMD: Handle overflow errors
ganesh-k13 f35bc45
TST: New tests for overflow in division operations
ganesh-k13 edcbf93
SIMD: Removed cvtozero
ganesh-k13 55ec35e
TST: Removed eval | Fixed raises cases
ganesh-k13 d61837d
TST: Changed `raise` to `warns`
ganesh-k13 e2a6580
TST: Add additional tests for division-by-zero and integer overflow
seberg 8a51635
MAINT: Remove nested NPY_UNLIKELY in division paths
seberg 3c6a62f
TST: Add unsigned integers to integer divide-by-zero test
seberg c9ef357
BUG: Added missing `NAME` key to loop generator
ganesh-k13 a463992
BUG, SIMD: Handle division overflow errors
ganesh-k13 e7f4199
TST: Modified tests to reflect new overflow
ganesh-k13 8b36969
Update numpy/core/src/umath/loops_arithmetic.dispatch.c.src
seberg File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, it was a small change in one of the loop definitions, didn't expect backport to fail as I only checked the diff :), hopefully, works now.