Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: change overloads to play nice with pyright. #22220

Merged
merged 2 commits into from Sep 7, 2022
Merged

BUG: change overloads to play nice with pyright. #22220

merged 2 commits into from Sep 7, 2022

Commits on Sep 7, 2022

  1. BUG: change overload order to play nice with pyright. 

    Pyright just chooses the first matching type whenever there is ambiguity in type resolution, which leads to NoReturn for the cross function in certain situations. Other overloads were changed to match. See ticket numpy#22146
    @iantra @charris
    iantra authored and charris committed Sep 7, 2022
    Copy the full SHA
    5a5b650 View commit details
    Browse the repository at this point in the history

  2. BUG: Introduce Unknown array type to deal with NDArray[Any] more grac… 

    …efully.
    @iantra @charris
    iantra authored and charris committed Sep 7, 2022
    Copy the full SHA
    336f3a4 View commit details
    Browse the repository at this point in the history