Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Ensure compile errors are raised correclty #21472

Merged
merged 1 commit into from May 9, 2022
Merged

BUG: Ensure compile errors are raised correclty #21472

merged 1 commit into from May 9, 2022

Commits on May 8, 2022

  1. BUG: Ensure compile errors are raised correclty 

    This has been bugging me for a bit.  The concurrent.futures Executor
requires checking the result for the error to be raised.  That makes
sense, but just means we need to consume the result explicitly here
to ensure we know about compile errors.

Otherwise, compile errors just pass silently (which is very confusing
if the old object files are still around and the tests run based on
the old version).
    @seberg @charris
    seberg authored and charris committed May 8, 2022
    Copy the full SHA
    cd57c8b View commit details
    Browse the repository at this point in the history