Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix setstate logic for empty arrays #20681

Merged
merged 3 commits into from Dec 30, 2021
Merged

BUG: Fix setstate logic for empty arrays #20681

merged 3 commits into from Dec 30, 2021

Commits on Dec 30, 2021

  1. BUG: Fix setstate logic for empty arrays 

    Also cleans up the clearing of the mem_handler slightly.  Lets try
to make sure it is always NULL when OWNDATA is not set (and an error
is given), just so there can't be any accidental double-frees.

Obviously, this function has more problems then the ones fixed here...

This introduces the NBYTES_ALLOCATED helper basically just for these
two places to fix the UHOH prints also...
    @seberg @charris
    seberg authored and charris committed Dec 30, 2021
    Copy the full SHA
    298b041 View commit details
    Browse the repository at this point in the history

  2. MAINT: Use PyArray_NBYTES_ALLOCATED for data setting

    @seberg @charris
    seberg authored and charris committed Dec 30, 2021
    Copy the full SHA
    13ae0a9 View commit details
    Browse the repository at this point in the history

  3. See if freeing nbytes or 1 works when nbytes-allocated does not

    @seberg @charris
    seberg authored and charris committed Dec 30, 2021
    Copy the full SHA
    34618d5 View commit details
    Browse the repository at this point in the history