Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Help boost::python libraries at least not crash #20618

Merged
merged 1 commit into from Dec 18, 2021

Commits on Dec 17, 2021

  1. MAINT: Help boost::python libraries at least not crash

    This adds an almost random "sanity check" to `PyArray_EquivTypes`
    for the sole purpose of allowing boost::python compiled libs to
    _not crash_.
    boost::python is buggy, it needs to be fixed.  This may break them
    (I am unsure), because some conversions which used to work may fail
    here (if they worked, they only worked because random type data may
    have matched up correctly for our scalar types).
    
    We could error, or warn or... but I hope boost::python will just fix
    this soon enough and future us can just delete the whole branch.
    
    Replaces numpygh-20507
    seberg authored and charris committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    c2495e3 View commit details
    Browse the repository at this point in the history