Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix float16 einsum fastpaths using wrong tempvar #20462

Merged
merged 2 commits into from Nov 26, 2021
Merged

BUG: Fix float16 einsum fastpaths using wrong tempvar #20462

merged 2 commits into from Nov 26, 2021

Commits on Nov 25, 2021

  1. BUG: Fix float16 einsum fastpaths using wrong tempvar

    @seberg @charris
    seberg authored and charris committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    18870a8 View commit details
    Browse the repository at this point in the history

  2. TST: Add exhaustive test for einsum specialized loops 

    This hopefully tests things well enough, at least some/most of the
paths get triggered and led to errors without the previous float16
typing fixes.

I manually confirmed that all paths that were *modified* in the
previous commit actually get hit with float16 specialized loops.

NOTE: This test may be a bit fragile with floating point roundoff
errors, and can in parts be relaxed if this happens.
    @seberg @charris
    seberg authored and charris committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    abb3dd3 View commit details
    Browse the repository at this point in the history