MAINT: Fix METH_NOARGS function signatures (#20368) #20412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The METH_NOARGS calling convention is required to take a second PyObject* which will always be NULL. This is a continuation of numpy#19058
|
I'm making this a draft until the CircleCI problem is better understood. |
|
close/reopen |
|
This change seems to work when merged and subsequent PRs have no problem, lets give it a shot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20368.
The METH_NOARGS calling convention is required to take a second PyObject* which will always be NULL.
This is a continuation of @joemarshall's work #19058.
This fixes all of the incorrect
METH_NOARGSsignatures that I managed to track down.We need this for pyodide/pyodide#1677.