Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix NaT handling in the PyArray_CompareFunc for datetime and timedelta #20081

Merged
merged 3 commits into from Oct 10, 2021
Merged

BUG: Fix NaT handling in the PyArray_CompareFunc for datetime and timedelta #20081

merged 3 commits into from Oct 10, 2021

Commits on Oct 10, 2021

  1. BUG: Fix NaT handling in the PyArray_CompareFunc for datetime and tim… 

    …edelta

In numpy#12658 and numpy#15068 the sort ordering for datetime and timedelta was changed
so that NaT sorts to the end, but the internal compare array function was not
updated.

Fixes numpy#19574.
    @asmeurer @charris
    asmeurer authored and charris committed Oct 10, 2021
    Copy the full SHA
    787e2cc View commit details
    Browse the repository at this point in the history

  2. Remove debug print

    @asmeurer @charris
    asmeurer authored and charris committed Oct 10, 2021
    Copy the full SHA
    9416e59 View commit details
    Browse the repository at this point in the history

  3. Fix the implementation of DATETIME_compare 

    I accidentally based it off the float compare template instead of the integer
compare template. It also now properly handles the case when both arguments
are NaT.
    @asmeurer @charris
    asmeurer authored and charris committed Oct 10, 2021
    Copy the full SHA
    73e7a12 View commit details
    Browse the repository at this point in the history