Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: np.tan(np.inf) test failure #19994

Merged
merged 1 commit into from Sep 29, 2021

Commits on Sep 28, 2021

  1. BUG: np.tan(np.inf) test failure

    Numpy has a test failure where `np.tan(np.inf)` is not raising "invalid". The bug is due to an underlying bug in Apple's Libm.  The bug is only present on arm64 and does not affect x86_64.
    
    The changes here apply to sin, cos, and tan. If the input is a non-finite value, then return `(x - x)`, which will raise "invalid" for `x=INFINITY` as well as return `NAN` for both `INFINITY` and `NAN` as input.
    
    Testing:
    (Note, the testing below is on top of another branch that fixes divide-by-zero failures in reciprocal)
    
    Before change:
    ```
    FAILED numpy/core/tests/test_umath.py::TestSpecialFloats::test_tan - AssertionError: FloatingPointError not raised by tan
    1 failed, 15589 passed, 302 skipped, 1268 deselected, 31 xfailed, 3 xpassed in 70.99s (0:01:10)
    ```
    
    After change:
    ```
    15590 passed, 302 skipped, 1268 deselected, 31 xfailed, 3 xpassed in 71.38s (0:01:11)
    ```
    Developer-Ecosystem-Engineering authored and charris committed Sep 28, 2021
    Copy the full SHA
    d169a12 View commit details
    Browse the repository at this point in the history