Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix reference count leak in ufunc dtype handling #19349

Merged
merged 2 commits into from Jun 25, 2021
Merged

BUG: Fix reference count leak in ufunc dtype handling #19349

merged 2 commits into from Jun 25, 2021

Commits on Jun 25, 2021

  1. BUG: Fix reference count leak 

    This adds a missing decref to the signature/dtype keyword argument
logic in reductions.
(The code will change quite a bit after 1.21, but this avoids a
reference count leak on 1.21.)
    @seberg @charris
    seberg authored and charris committed Jun 25, 2021
    Copy the full SHA
    3b24735 View commit details
    Browse the repository at this point in the history

  2. BUG: Remove unnecessary incref in type resolution 

    `ensure_dtype_nbo()` already increments the reference count,
so the INCREF is not necessary here.
    @seberg @charris
    seberg authored and charris committed Jun 25, 2021
    Copy the full SHA
    70ac04c View commit details
    Browse the repository at this point in the history