BUG: Remove temporary change of descr/flags in VOID functions #18462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done using a hack around stack allocated arrays, which requires some dark magic with respect to the setting the base object (we skip normal arrays and INCREF/DECREF during base setting, which _does_ work for such static arrays, but only if we give them a (not quite) fake refcount of 1 and set the base and their type correctly to PyArrayType. Closes numpygh-15387
charris
added
00 - Bug
component: numpy._core
08 - Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport or #15392.
This is done using a hack around stack allocated arrays, which
requires some dark magic with respect to the setting the base
object (we skip normal arrays and INCREF/DECREF during base setting,
which does work for such static arrays, but only if we give them
a (not quite) fake refcount of 1 and set the base and their type
correctly to PyArrayType.
Closes gh-15387