BUG: diagflat
could overflow on windows or 32-bit platforms
#18459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18455.
Closes #18449.
For particularly large input arrays the
np.diagflat
function could yield non-zero diagonal elements due to integer overflow,the latter facilitated by the default
np.arange
integer-dtype beingnp.int32
on windows.This PR fixes aforementioned issue by explicitly setting the dtype to
np.intp
.