-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Fix version of wheel to support Python 3.10 #18389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, if CI doesn't expose any backward-incompatibilities.
Thanks @frenzymadness . |
Hello. Which Numpy version will this patch be in? Thanks! |
1.21.x will be the first to support Python 3.10 but we won't release wheels for it until 3.10.0 is released. |
Not releasing wheels before the final version of Python is out is okay (even it makes every installation much longer) but this fix is important also for installing from the sources. Right now, the installation from the source code fails unless you use |
Python 3.10 rc1 is out (ABI is frozen), so it’s reasonable to make wheels now, no? |
Python 3.10 rc1 actually broke some things. |
Yes I just saw that (with power function) |
The latest version of numpy is not installable from source code with Python 3.10. The reason is a bug (incompatibility) in the older versions of wheel package. For more info see this issue: pypa/wheel#354
The problem is already fixed in the latest wheel release (0.36.2).
What happens when you try to install the latest numpy from the master branch with Python 3.10:
With this patch it works like a charm: