Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Keep ignoring most errors during array-protocol lookup #18201

Merged
merged 1 commit into from
Jan 21, 2021

Commits on Jan 21, 2021

  1. BUG: Keep ignoring most errors during array-protocol lookup

    Closes (the later point) in numpygh-17965 and reverts parts of
    numpygh-17817.
    Shapely did rely on being able to raise a NotImplementedError
    which then got ignored in the attribute lookup.
    Arguably, this should probably just raise an AttributeError to
    achieve that behaviour, but it means we can't just rip the band-aid
    off here.
    
    Since 1.20 is practically released, just reverting most of the change
    (leaving only recursion and memory error which are both arguably
    pretty fatal).
    Ignoring most errors should be deprecated (and I am happy to do so),
    but it is not important enough for 1.20 or very important in itself.
    
    Closes numpygh-17965
    seberg authored and charris committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    dff151e View commit details
    Browse the repository at this point in the history