BUG: Ignore fewer errors during array-coercion #18015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes it so that we only ignore attribute errors on looking up `__array__` and propagate errors when checking for sequences `len(obj)` if those errors are either RecursionError or MemoryError (we consider them unrecoverable). Also adds test for bad recursive array-like with sequence as reported in numpygh-17785. The test might be flaky/more complicated in which case it should probably just be deleted.
charris
added
00 - Bug
component: numpy._core
08 - Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #17817.
This changes it so that we only ignore attribute errors on
looking up
__array__and propagate errors when checkingfor sequences
len(obj)if those errors are eitherRecursionError or MemoryError (we consider them unrecoverable).
Also adds test for bad recursive array-like with sequence
as reported in gh-17785. The test might be flaky/more complicated
in which case it should probably just be deleted.