Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Implement sliding window #17394

Merged
merged 56 commits into from
Nov 5, 2020
Merged

ENH: Implement sliding window #17394

merged 56 commits into from
Nov 5, 2020

Commits on Oct 29, 2020

  1. implement sliding_window_view numpy#7753 

    Test cases are shown in the issue page.
    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    3b95d56 View commit details
    Browse the repository at this point in the history

  2. Add Example Cases

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    53ee251 View commit details
    Browse the repository at this point in the history

  3. Add step_size and N-dim support

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    226ccc9 View commit details
    Browse the repository at this point in the history

  4. Add shape and step_size check. Remove warning.

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    8d20cba View commit details
    Browse the repository at this point in the history

  5. Remove shape default 

    Add step_size default's description.
    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    8e25a5a View commit details
    Browse the repository at this point in the history

  6. Give proper parameter name 'step'

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    2b10398 View commit details
    Browse the repository at this point in the history

  7. fix a parameter description mistake

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    ea98869 View commit details
    Browse the repository at this point in the history

  8. implement test function for sliding_window_view()

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    158f770 View commit details
    Browse the repository at this point in the history

  9. implement test function for sliding_window_view()

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    9f71442 View commit details
    Browse the repository at this point in the history

  10. Fix according to @eric-wieser comments

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    49e3941 View commit details
    Browse the repository at this point in the history

  11. Change arange to ogrid in Examples

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    d8d87b1 View commit details
    Browse the repository at this point in the history

  12. remove np.squeeze on return line

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    24c18bd View commit details
    Browse the repository at this point in the history

  13. Clarify document to avoid parameter confusion.

    @zklaus
    Fanjin Zeng authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    b242585 View commit details
    Browse the repository at this point in the history

  14. add writable and more explanation in docs

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    f39a3e0 View commit details
    Browse the repository at this point in the history

  15. resolve a write conflit

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    44145a2 View commit details
    Browse the repository at this point in the history

  16. fixes according to @seberg review

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    e3402a1 View commit details
    Browse the repository at this point in the history

  17. resolve write hazard

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    d44a438 View commit details
    Browse the repository at this point in the history

  18. remove outdated docs.

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    73a6f76 View commit details
    Browse the repository at this point in the history

  19. change referring according to @mattip. 

    change 'writeable' to 'readonly' as @seberg suggest.
remove 'step' as @eric-wieser request
    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    31d6482 View commit details
    Browse the repository at this point in the history

  20. fix test minor error

    @zklaus
    Fanjin authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    2f1fe8c View commit details
    Browse the repository at this point in the history

  21. DOC: Grammar fixes

    @eric-wieser @zklaus
    eric-wieser authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    543ecaf View commit details
    Browse the repository at this point in the history

  22. STY: Add missing line break required by PEP8

    @eric-wieser @zklaus
    eric-wieser authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    f8003a1 View commit details
    Browse the repository at this point in the history

  23. + Change readonly parameter to writeable. 

    + Update writeable description.
+ Fix a few parameter checks.
+ Other minor improvements.
    @fanjin-z @zklaus
    fanjin-z authored and zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    8b3e073 View commit details
    Browse the repository at this point in the history

  24. Move to new api as proposed by @eric-wieser 

    - Change api to follow suggestion by Eric Wieser in
  numpy#10771 (comment)
- Update docstring
- Add more tests
    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    39cc036 View commit details
    Browse the repository at this point in the history

  25. Improve documentation

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    af2c5e1 View commit details
    Browse the repository at this point in the history

  26. Add sliding_window_view to documentation index

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    60b084b View commit details
    Browse the repository at this point in the history

  27. Apply suggestions from code review 

    Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
    @zklaus @eric-wieser
    zklaus and eric-wieser committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    0152b5b View commit details
    Browse the repository at this point in the history

  28. Fix window shape check

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    39f94c8 View commit details
    Browse the repository at this point in the history

  29. Add sliding_window_view to __all__

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    e9d2964 View commit details
    Browse the repository at this point in the history

  30. Add tests for error cases

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    a967d9d View commit details
    Browse the repository at this point in the history

  31. Add array_function dispatching

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    2aa0c17 View commit details
    Browse the repository at this point in the history

  32. Change dispatcher argument defaults to None

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    54b735e View commit details
    Browse the repository at this point in the history

  33. Simplify array function dispatching

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    ab64f1c View commit details
    Browse the repository at this point in the history

  34. Added "np." prefix to doctests

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    979059e View commit details
    Browse the repository at this point in the history

  35. Split tests

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    6ac510a View commit details
    Browse the repository at this point in the history

  36. Improved docstring

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    c410510 View commit details
    Browse the repository at this point in the history

  37. Add release note

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    a5199af View commit details
    Browse the repository at this point in the history

  38. Fix docstring formatting

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    6e16bd2 View commit details
    Browse the repository at this point in the history

  39. Fix doctest

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    beff300 View commit details
    Browse the repository at this point in the history

  40. Remove namespacing in documentation indexing

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    c05620b View commit details
    Browse the repository at this point in the history

  41. Improve docstring

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    592877e View commit details
    Browse the repository at this point in the history

  42. Improved docstring

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    dd058b8 View commit details
    Browse the repository at this point in the history

  43. Simplified docstring

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    79ef657 View commit details
    Browse the repository at this point in the history

  44. Improve docstring to make pseudo code stand out

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    59a11f5 View commit details
    Browse the repository at this point in the history

  45. Improve docstring

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    64c11d9 View commit details
    Browse the repository at this point in the history

  46. Add simple application example

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    e7c3d03 View commit details
    Browse the repository at this point in the history

  47. Correct release note

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    29a0fd5 View commit details
    Browse the repository at this point in the history

  48. Improve link with as_strides

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    c681bac View commit details
    Browse the repository at this point in the history

  49. Add note about performance

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    2e933b9 View commit details
    Browse the repository at this point in the history

  50. Tidy up main doc string

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    84b6953 View commit details
    Browse the repository at this point in the history

  51. Make language on performance warning stronger

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    d91a8cb View commit details
    Browse the repository at this point in the history

  52. Bugfix: pass subok and writeable to as_strided

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    267bfbb View commit details
    Browse the repository at this point in the history

  53. Add writeable test

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    0c31540 View commit details
    Browse the repository at this point in the history

  54. Add subok test

    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    8ea7415 View commit details
    Browse the repository at this point in the history

  55. Change subok test to use custom array subclass instead of unsupported… 

    … MaskedArray
    @zklaus
    zklaus committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    e2cd3dd View commit details
    Browse the repository at this point in the history

  56. Add version added information 

    Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
    @zklaus @eric-wieser
    zklaus and eric-wieser committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    c6ef8d6 View commit details
    Browse the repository at this point in the history